[8.0] fix: do not reset files for not yet submitted jobs - #8583
Open
atsareg wants to merge 1 commit into
Open
Conversation
Contributor
|
Looking at this PR, I realize that there is the "same" function in https://github.com/DIRACGrid/DIRAC/blob/rel-v8r0/src/DIRAC/TransformationSystem/Client/RequestTasks.py#L366 which is certainly working fine (in the context of replication transformations, but still...). Can you compare the 2 and check their differences? |
Contributor
Author
|
Yes, this is a good confirmation of this PR. In the replication transformations the files are ONLY checked for tasks that were created and got the ExternalID: .Here, there should be the same logic: files are reserved while the jobs are not yet submitted, those should not be reset to UNUSED because it is just a slow job submission in an overloaded system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The removed operation was reseting files to Unused for tasks that were created but job not yet submitted. As a result new jobs were created for the same files multiple files.
A fix was needed in the pre-commit configuration for the flynt part as by default it uses python3.14 version not compatible with 3.11. I think this should be harmless
BEGINRELEASENOTES
*Transformation
FIX: WorkflowTasks - do not reset files for not yet submitted jobs
ENDRELEASENOTES